feat: evolve textfx into a mini shell #62

pi-agent · 2026-03-18T18:09:58+08:00

pi-agent commented

2026-03-18 18:09:58 +08:00

User description

概述

将 textfx 从简单的文本处理器链重构为最小 shell 风格 DSL，支持管道、条件、循环等控制流。

主要变更

架构重构

从「扫描-构建」模式重构为三层架构：
- Tokenizer：词法分析
- Parser：AST 构建
- Executor：执行引擎
使用结构化 AST 节点（CommandNode、PipelineNode、IfNode、WhileNode、Script）

新增 shell-like 语法

管道：|
顺序执行：;
条件执行：&& / ||
重定向：> / >>
控制流：if ... then ... else ... fi
循环：while ... do ... done

新增内建命令

test / [：条件测试
!：逻辑取反
true / false：真假命令

安全限制

同一用户同时只能运行一个 textfx 脚本
单个脚本最长执行时间 60 秒
while 循环最大迭代次数 100 次

测试

新增 tests/test_textfx_shell.py：19 个 shell 语法测试
新增 tests/test_textfx_runtime_limits.py：3 个运行限制测试
所有现有测试通过

文档

更新 konabot/docs/user/textfx.txt，补充所有新语法说明和示例

PR Type

Enhancement

Description

将 textfx 重构为迷你 shell DSL
新增管道、条件、循环等控制流语法
新增 true/false/test 内建命令
添加超时与并发限制及相关测试

Diagram Walkthrough

flowchart LR
  Input["用户输入脚本"]
  Tokenizer["Tokenizer 词法分析"]
  Parser["Parser AST 构建"]
  Executor["Executor 执行引擎"]
  Builtins["内建命令 true/false/test"]
  ControlFlow["控制流 if/while/&&/||"]
  Input -- "文本" --> Tokenizer
  Tokenizer -- "tokens" --> Parser
  Parser -- "AST 节点" --> Executor
  Executor -- "调用" --> Builtins
  Executor -- "处理" --> ControlFlow

File Walkthrough

Relevant files

Enhancement

__init__.py `注册新增内建命令处理器` konabot/plugins/handle_text/init.py 注册新增的 `THTrue`、`THFalse`、`THTest` 处理器	+48/-3
base.py `重构执行引擎支持 AST 语句分发` konabot/plugins/handle_text/base.py 将 `run_pipeline` 从遍历 `command_groups` 重构为遍历 `statements` 新增对 `IfNode` 和 `WhileNode` AST 节点的分发执行为整个语句执行添加统一的异常捕获移除旧的逐命令管道执行和重定向逻辑	+475/-239
unix_handlers.py `新增 true/false/test 内建命令` konabot/plugins/handle_text/handlers/unix_handlers.py 新增 `THTrue` 命令，始终返回成功新增 `THFalse` 命令，始终返回失败新增 `THTest` 命令，支持字符串非空、`-n`/`-z`、字符串比较、整数比较及方括号别名	+74/-3

Tests

test_textfx_runtime_limits.py `新增运行时限制相关测试` tests/test_textfx_runtime_limits.py 新增 `_get_textfx_user_key` 的三种场景单元测试（群聊、私聊、session 回退）新增超时常量 `TEXTFX_MAX_RUNTIME_SECONDS` 验证测试新增并发执行限制 `_textfx_running_users` 集合行为测试	+75/-0
test_textfx_shell.py `新增 shell 语法全面测试用例` tests/test_textfx_shell.py 新增 19 个测试覆盖 shell 语法解析与执行测试管道、重定向、`&&`/`\|\|` 短路、`!` 取反、引号与 trim 测试 `if/then/else/fi` 条件语句及嵌套测试 `while/do/done` 循环及迭代次数限制	+207/-0

Documentation

textfx.txt

补充 shell 语法用户文档

konabot/docs/user/textfx.txt

新增 true/false/test/[ 命令文档及示例
新增 if/then/else/fi 条件语句文档及示例
新增 while/do/done 循环语句文档及示例
说明循环次数限制等安全机制

+85/-1

### **User description** ## 概述将 textfx 从简单的文本处理器链重构为最小 shell 风格 DSL，支持管道、条件、循环等控制流。 ## 主要变更 ### 架构重构 - 从「扫描-构建」模式重构为三层架构： - Tokenizer：词法分析 - Parser：AST 构建 - Executor：执行引擎 - 使用结构化 AST 节点（CommandNode、PipelineNode、IfNode、WhileNode、Script） ### 新增 shell-like 语法 - 管道：`|` - 顺序执行：`;` - 条件执行：`&&` / `||` - 重定向：`>` / `>>` - 控制流：`if ... then ... else ... fi` - 循环：`while ... do ... done` ### 新增内建命令 - `test` / `[`：条件测试 - `!`：逻辑取反 - `true` / `false`：真假命令 ### 安全限制 - 同一用户同时只能运行一个 textfx 脚本 - 单个脚本最长执行时间 60 秒 - while 循环最大迭代次数 100 次 ## 测试 - 新增 `tests/test_textfx_shell.py`：19 个 shell 语法测试 - 新增 `tests/test_textfx_runtime_limits.py`：3 个运行限制测试 - 所有现有测试通过 ## 文档 - 更新 `konabot/docs/user/textfx.txt`，补充所有新语法说明和示例 ___ ### **PR Type** Enhancement ___ ### **Description** - 将 textfx 重构为迷你 shell DSL - 新增管道、条件、循环等控制流语法 - 新增 `true`/`false`/`test` 内建命令 - 添加超时与并发限制及相关测试 ___ ### Diagram Walkthrough ```mermaid flowchart LR Input["用户输入脚本"] Tokenizer["Tokenizer 词法分析"] Parser["Parser AST 构建"] Executor["Executor 执行引擎"] Builtins["内建命令 true/false/test"] ControlFlow["控制流 if/while/&&/||"] Input -- "文本" --> Tokenizer Tokenizer -- "tokens" --> Parser Parser -- "AST 节点" --> Executor Executor -- "调用" --> Builtins Executor -- "处理" --> ControlFlow ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>__init__.py</strong><dd><code>注册新增内建命令处理器</code>                                                                                            </dd></summary> <hr> konabot/plugins/handle_text/__init__.py - 注册新增的 `THTrue`、`THFalse`、`THTest` 处理器 </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/plugins/handle_text/__init__.py">+48/-3</a>    </td> </tr> <tr> <td> <details> <summary><strong>base.py</strong><dd><code>重构执行引擎支持 AST 语句分发</code>                                                                                </dd></summary> <hr> konabot/plugins/handle_text/base.py <ul><li>将 <code>run_pipeline</code> 从遍历 <code>command_groups</code> 重构为遍历 <code>statements</code><br> <li> 新增对 <code>IfNode</code> 和 <code>WhileNode</code> AST 节点的分发执行<br> <li> 为整个语句执行添加统一的异常捕获<br> <li> 移除旧的逐命令管道执行和重定向逻辑</ul> </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/plugins/handle_text/base.py">+475/-239</a></td> </tr> <tr> <td> <details> <summary><strong>unix_handlers.py</strong><dd><code>新增 true/false/test 内建命令</code>                                                                    </dd></summary> <hr> konabot/plugins/handle_text/handlers/unix_handlers.py <ul><li>新增 <code>THTrue</code> 命令，始终返回成功<br> <li> 新增 <code>THFalse</code> 命令，始终返回失败<br> <li> 新增 <code>THTest</code> 命令，支持字符串非空、<code>-n</code>/<code>-z</code>、字符串比较、整数比较及方括号别名</ul> </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/plugins/handle_text/handlers/unix_handlers.py">+74/-3</a>    </td> </tr> </table></td></tr><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>test_textfx_runtime_limits.py</strong><dd><code>新增运行时限制相关测试</code>                                                                                            </dd></summary> <hr> tests/test_textfx_runtime_limits.py <ul><li>新增 <code>_get_textfx_user_key</code> 的三种场景单元测试（群聊、私聊、session 回退）<br> <li> 新增超时常量 <code>TEXTFX_MAX_RUNTIME_SECONDS</code> 验证测试<br> <li> 新增并发执行限制 <code>_textfx_running_users</code> 集合行为测试</ul> </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/tests/test_textfx_runtime_limits.py">+75/-0</a>    </td> </tr> <tr> <td> <details> <summary><strong>test_textfx_shell.py</strong><dd><code>新增 shell 语法全面测试用例</code>                                                                                </dd></summary> <hr> tests/test_textfx_shell.py <ul><li>新增 19 个测试覆盖 shell 语法解析与执行<br> <li> 测试管道、重定向、<code>&&</code>/<code>||</code> 短路、<code>!</code> 取反、引号与 trim<br> <li> 测试 <code>if/then/else/fi</code> 条件语句及嵌套<br> <li> 测试 <code>while/do/done</code> 循环及迭代次数限制</ul> </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/tests/test_textfx_shell.py">+207/-0</a>  </td> </tr> </table></td></tr><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>textfx.txt</strong><dd><code>补充 shell 语法用户文档</code>                                                                                    </dd></summary> <hr> konabot/docs/user/textfx.txt <ul><li>新增 <code>true</code>/<code>false</code>/<code>test</code>/<code>[</code> 命令文档及示例<br> <li> 新增 <code>if/then/else/fi</code> 条件语句文档及示例<br> <li> 新增 <code>while/do/done</code> 循环语句文档及示例<br> <li> 说明循环次数限制等安全机制</ul> </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/docs/user/textfx.txt">+85/-1</a>    </td> </tr> </table></td></tr></tr></tbody></table> </details> ___

pi-agent added 1 commit 2026-03-18 18:09:58 +08:00

feat: evolve textfx into a mini shell 0cb236b561

kagami-review commented

2026-03-18 18:10:53 +08:00

PR Reviewer Guide 🔍

(Review updated until commit `8f40572a38`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

测试不充分

test_textfx_timeout_limit 实际上并没有测试超时机制是否生效，只是验证了常量值和脚本能解析。test_textfx_concurrent_limit 也只是手动操作 set 来验证 add/discard，没有真正测试并发场景下第二个请求是否会被拒绝。这些测试给人一种有覆盖的错觉，但实际上没有验证核心的运行时限制逻辑。

async def test_textfx_timeout_limit():
    """测试脚本执行超时限制"""
    runner = PipelineRunner.get_runner()

    # 创建一个会超时的脚本（while true 会触发迭代限制，但我们用 sleep 模拟长时间运行）
    # 由于实际超时是 60 秒，我们不能真的等那么久，所以这个测试验证超时机制存在
    script = "echo start"
    parsed = runner.parse_pipeline(script)
    assert not isinstance(parsed, str), "脚本解析应该成功"

    # 验证 TEXTFX_MAX_RUNTIME_SECONDS 常量存在且合理
    assert TEXTFX_MAX_RUNTIME_SECONDS == 60


@pytest.mark.asyncio
async def test_textfx_concurrent_limit():
    """测试同一用户并发执行限制"""
    user_key = "test:group:user123"

    # 清理可能的残留状态
    _textfx_running_users.discard(user_key)

    # 模拟第一个脚本正在运行
    assert user_key not in _textfx_running_users
    _textfx_running_users.add(user_key)

    # 验证用户已被标记为运行中
    assert user_key in _textfx_running_users

    # 清理
    _textfx_running_users.discard(user_key)
    assert user_key not in _textfx_running_users

异常吞没

捕获了所有 Exception 并返回通用错误消息，这会掩盖具体的错误类型（如 asyncio.TimeoutError、RecursionError 等）。建议至少在错误消息中区分超时和其他异常，或者让特定异常（如 KeyboardInterrupt、SystemExit）向上传播，避免调试困难。

except Exception as e:
    logger.error(f"Pipeline execution failed: {e}")
    logger.exception(e)
    results.append(
        TextHandleResult(code=-1, ostream="处理流水线时出现 python 错误")
    )

输入注入风险

THTest 的 handle 方法直接使用用户提供的 args 进行 int() 转换和字符串比较，虽然当前实现看起来安全，但如果未来扩展支持更多操作符（如文件测试 -f、-d），需要注意不要暴露文件系统访问。当前的错误消息会将用户输入原样返回（f"test 不支持的表达式: {' '.join(args)}"），在某些上下文中可能被利用做消息注入。

async def handle(
    self, env: TextHandlerEnvironment, istream: str | None, args: list[str]
) -> TextHandleResult:
    expr = list(args)

    # 支持方括号语法：[ expr ] 会自动移除末尾的 ]
    if expr and expr[-1] == "]":
        expr = expr[:-1]

    if not expr:
        return TextHandleResult(1, None)

    if len(expr) == 1:
        return self._bool_result(len(expr[0]) > 0)

    if len(expr) == 2:
        op, value = expr
        if op == "-n":
            return self._bool_result(len(value) > 0)
        if op == "-z":
            return self._bool_result(len(value) == 0)
        return TextHandleResult(2, f"test 不支持的表达式: {' '.join(args)}")

    if len(expr) == 3:
        left, op, right = expr
        if op == "=":
            return self._bool_result(left == right)
        if op == "!=":
            return self._bool_result(left != right)
        if op in {"-eq", "-ne", "-gt", "-ge", "-lt", "-le"}:
            try:
                li = int(left)
                ri = int(right)
            except ValueError:
                return TextHandleResult(2, "test 的数字比较参数必须是整数")
            mapping = {
                "-eq": li == ri,
                "-ne": li != ri,
                "-gt": li > ri,
                "-ge": li >= ri,
                "-lt": li < ri,
                "-le": li <= ri,
            }
            return self._bool_result(mapping[op])
        return TextHandleResult(2, f"test 不支持的操作符: {op}")

    return TextHandleResult(2, f"test 不支持的表达式: {' '.join(args)}")

## PR Reviewer Guide 🔍 #### (Review updated until commit https://gitea.service.jazzwhom.top/mttu-developers/konabot/commit/8f40572a389a53ec4869af892d8df4292893a66a) Here are some key observations to aid the review process: <table> <tr><td>⏱️ <strong>Estimated effort to review</strong>: 3 🔵🔵🔵⚪⚪</td></tr> <tr><td>🧪 <strong>PR contains tests</strong></td></tr> <tr><td>🔒 <strong>No security concerns identified</strong></td></tr> <tr><td>⚡ <strong>Recommended focus areas for review</strong><br><br> <details><summary><a href='https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/tests/test_textfx_runtime_limits.py#L44-L75'><strong>测试不充分</strong></a> `test_textfx_timeout_limit` 实际上并没有测试超时机制是否生效，只是验证了常量值和脚本能解析。`test_textfx_concurrent_limit` 也只是手动操作 set 来验证 add/discard，没有真正测试并发场景下第二个请求是否会被拒绝。这些测试给人一种有覆盖的错觉，但实际上没有验证核心的运行时限制逻辑。 </summary> ```python async def test_textfx_timeout_limit(): """测试脚本执行超时限制""" runner = PipelineRunner.get_runner() # 创建一个会超时的脚本（while true 会触发迭代限制，但我们用 sleep 模拟长时间运行） # 由于实际超时是 60 秒，我们不能真的等那么久，所以这个测试验证超时机制存在 script = "echo start" parsed = runner.parse_pipeline(script) assert not isinstance(parsed, str), "脚本解析应该成功" # 验证 TEXTFX_MAX_RUNTIME_SECONDS 常量存在且合理 assert TEXTFX_MAX_RUNTIME_SECONDS == 60 @pytest.mark.asyncio async def test_textfx_concurrent_limit(): """测试同一用户并发执行限制""" user_key = "test:group:user123" # 清理可能的残留状态 _textfx_running_users.discard(user_key) # 模拟第一个脚本正在运行 assert user_key not in _textfx_running_users _textfx_running_users.add(user_key) # 验证用户已被标记为运行中 assert user_key in _textfx_running_users # 清理 _textfx_running_users.discard(user_key) assert user_key not in _textfx_running_users ``` </details> <details><summary><a href='https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/plugins/handle_text/base.py#L573-L578'><strong>异常吞没</strong></a> 捕获了所有 `Exception` 并返回通用错误消息，这会掩盖具体的错误类型（如 `asyncio.TimeoutError`、`RecursionError` 等）。建议至少在错误消息中区分超时和其他异常，或者让特定异常（如 `KeyboardInterrupt`、`SystemExit`）向上传播，避免调试困难。 </summary> ```python except Exception as e: logger.error(f"Pipeline execution failed: {e}") logger.exception(e) results.append( TextHandleResult(code=-1, ostream="处理流水线时出现 python 错误") ) ``` </details> <details><summary><a href='https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/plugins/handle_text/handlers/unix_handlers.py#L117-L163'><strong>输入注入风险</strong></a> `THTest` 的 `handle` 方法直接使用用户提供的 args 进行 `int()` 转换和字符串比较，虽然当前实现看起来安全，但如果未来扩展支持更多操作符（如文件测试 `-f`、`-d`），需要注意不要暴露文件系统访问。当前的错误消息会将用户输入原样返回（`f"test 不支持的表达式: {' '.join(args)}"`），在某些上下文中可能被利用做消息注入。 </summary> ```python async def handle( self, env: TextHandlerEnvironment, istream: str | None, args: list[str] ) -> TextHandleResult: expr = list(args) # 支持方括号语法：[ expr ] 会自动移除末尾的 ] if expr and expr[-1] == "]": expr = expr[:-1] if not expr: return TextHandleResult(1, None) if len(expr) == 1: return self._bool_result(len(expr[0]) > 0) if len(expr) == 2: op, value = expr if op == "-n": return self._bool_result(len(value) > 0) if op == "-z": return self._bool_result(len(value) == 0) return TextHandleResult(2, f"test 不支持的表达式: {' '.join(args)}") if len(expr) == 3: left, op, right = expr if op == "=": return self._bool_result(left == right) if op == "!=": return self._bool_result(left != right) if op in {"-eq", "-ne", "-gt", "-ge", "-lt", "-le"}: try: li = int(left) ri = int(right) except ValueError: return TextHandleResult(2, "test 的数字比较参数必须是整数") mapping = { "-eq": li == ri, "-ne": li != ri, "-gt": li > ri, "-ge": li >= ri, "-lt": li < ri, "-le": li <= ri, } return self._bool_result(mapping[op]) return TextHandleResult(2, f"test 不支持的操作符: {op}") return TextHandleResult(2, f"test 不支持的表达式: {' '.join(args)}") ``` </details> </td></tr> </table>

kagami-review commented

2026-03-18 18:11:22 +08:00

PR Code Suggestions ✨

Latest suggestions up to 8f40572
Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	内部错误时缺少提前返回逻辑旧代码中，管道组内某条命令失败（`code != 0`）时会立即中止整条流水线并返回。新代码的 `for statement` 循环里捕获了异常，但对于 `_execute_group`/`_execute_if`/`_execute_while` 返回非零 `code` 的情况没有做任何中止处理，所有 statement 都会无条件继续执行。这可能导致本应中止的脚本继续运行后续语句，改变了原有的错误传播语义。建议在 `code < 0`（内部错误）时提前返回，或根据设计意图保留短路逻辑。 konabot/plugins/handle_text/base.py [565-573] for statement in pipeline.statements: try: if isinstance(statement, IfNode): - results.append(await self._execute_if(statement, istream, env)) + result = await self._execute_if(statement, istream, env) elif isinstance(statement, WhileNode): - results.append(await self._execute_while(statement, istream, env)) + result = await self._execute_while(statement, istream, env) else: - results.append(await self._execute_group(statement, istream, env)) + result = await self._execute_group(statement, istream, env) + results.append(result) + if result.code < 0: + return results except Exception as e: Suggestion importance[1-10]: 4 __ Why: The suggestion raises a valid point about error propagation semantics changing from the old code. However, the old code's early-return behavior was specifically for pipeline within a command group (pipe-separated commands), not across semicolon-separated statements. In shell semantics, semicolon-separated statements are independent and should all execute regardless of prior failures. The new code delegates to `_execute_group`, `_execute_if`, and `_execute_while` which likely handle internal pipe-level error propagation themselves. The suggestion to short-circuit on `code < 0` is a reasonable defensive measure but may not align with the intended shell-like semantics of the refactor. The improvement is minor and speculative.	Low

Previous suggestions

Suggestions up to commit 8f40572

Category	Suggestion	Impact
Possible issue	缺少异常捕获导致错误未处理旧代码在执行管道命令时有 `try/except` 包裹，能捕获意外的 Python 异常并返回友好错误信息。新代码移除了这层保护，`_execute_if`、`_execute_while`、`_execute_group` 中任何未预期的异常都会直接向上抛出，可能导致用户看到原始堆栈或 bot 崩溃。建议在循环体外加上异常捕获。 konabot/plugins/handle_text/base.py [565-571] for statement in pipeline.statements: - if isinstance(statement, IfNode): - results.append(await self._execute_if(statement, istream, env)) - elif isinstance(statement, WhileNode): - results.append(await self._execute_while(statement, istream, env)) - else: - results.append(await self._execute_group(statement, istream, env)) + try: + if isinstance(statement, IfNode): + results.append(await self._execute_if(statement, istream, env)) + elif isinstance(statement, WhileNode): + results.append(await self._execute_while(statement, istream, env)) + else: + results.append(await self._execute_group(statement, istream, env)) + except Exception as e: + logger.error(f"Pipeline execution failed: {e}") + logger.exception(e) + results.append( + TextHandleResult(code=-1, ostream="处理流水线时出现 python 错误") + ) + return results Suggestion importance[1-10]: 6 __ Why: The suggestion correctly observes that the old code had `try/except` wrapping pipeline execution, and the new code removes it. Unhandled exceptions in `_execute_if`, `_execute_while`, or `_execute_group` could propagate and crash the bot or expose raw tracebacks. However, it's possible the exception handling was moved into those helper methods (which aren't shown in the diff), so this is a reasonable but not certain concern. The `improved_code` accurately reflects the suggested change.	Low
Possible issue	方括号别名检测逻辑永远不生效当 `THTest` 通过 `keywords = ["["]` 以 `[` 别名被调用时，这里的 `self.name` 始终是 `"test"`，不会等于 `"["`，因此永远不会进入该分支。应该通过检查参数（例如 `args` 的第一个元素或调用名）来判断是否以 `[` 形式调用，并在此时验证末尾是否有匹配的 `]`，否则报错提示语法不正确。 konabot/plugins/handle_text/handlers/unix_handlers.py [121-122] `-if self.name == "[": - pass +# Note: bracket-style invocation detection should be based on +# the actual invoked name passed by the caller, not self.name. +# If the caller does not pass invoked name, consider checking +# if the last arg is ']' and require it for bracket syntax.` Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies that `self.name` is always `"test"` since `keywords` only adds aliases for lookup, not for changing `self.name`. However, the `improved_code` is just comments rather than actual working code, and the current code still handles `]` removal on line 124-125 regardless of invocation method, so the practical impact is limited — the bracket syntax still works, just without strict validation of the closing `]`.	Low

## PR Code Suggestions ✨  Latest suggestions up to 8f40572 Explore these optional code suggestions: <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion                                                                                                                                    </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>Possible issue</td> <td> <details><summary>内部错误时缺少提前返回逻辑</summary> ___ **旧代码中，管道组内某条命令失败（<code>code != 0</code>）时会立即中止整条流水线并返回。新代码的 <code>for statement</code> 循环里捕获了异常，但对于 <br><code>_execute_group</code>/<code>_execute_if</code>/<code>_execute_while</code> 返回非零 <code>code</code> 的情况没有做任何中止处理，所有 statement <br>都会无条件继续执行。这可能导致本应中止的脚本继续运行后续语句，改变了原有的错误传播语义。建议在 <code>code < 0</code>（内部错误）时提前返回，或根据设计意图保留短路逻辑。** [konabot/plugins/handle_text/base.py [565-573]](https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/plugins/handle_text/base.py#L565-L573) ```diff for statement in pipeline.statements: try: if isinstance(statement, IfNode): - results.append(await self._execute_if(statement, istream, env)) + result = await self._execute_if(statement, istream, env) elif isinstance(statement, WhileNode): - results.append(await self._execute_while(statement, istream, env)) + result = await self._execute_while(statement, istream, env) else: - results.append(await self._execute_group(statement, istream, env)) + result = await self._execute_group(statement, istream, env) + results.append(result) + if result.code < 0: + return results except Exception as e: ``` <details><summary>Suggestion importance[1-10]: 4</summary> __ Why: The suggestion raises a valid point about error propagation semantics changing from the old code. However, the old code's early-return behavior was specifically for pipeline *within* a command group (pipe-separated commands), not across semicolon-separated statements. In shell semantics, semicolon-separated statements are independent and should all execute regardless of prior failures. The new code delegates to `_execute_group`, `_execute_if`, and `_execute_while` which likely handle internal pipe-level error propagation themselves. The suggestion to short-circuit on `code < 0` is a reasonable defensive measure but may not align with the intended shell-like semantics of the refactor. The improvement is minor and speculative. </details></details></td><td align=center>Low </td></tr></tr></tbody></table> ___ #### Previous suggestions <details><summary>Suggestions up to commit 8f40572</summary> <br><table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion                                                                                                                                    </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=2>Possible issue</td> <td> <details><summary>缺少异常捕获导致错误未处理</summary> ___ **旧代码在执行管道命令时有 <code>try/except</code> 包裹，能捕获意外的 Python <br>异常并返回友好错误信息。新代码移除了这层保护，<code>_execute_if</code>、<code>_execute_while</code>、<code>_execute_group</code> <br>中任何未预期的异常都会直接向上抛出，可能导致用户看到原始堆栈或 bot 崩溃。建议在循环体外加上异常捕获。** [konabot/plugins/handle_text/base.py [565-571]](https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/plugins/handle_text/base.py#L565-L571) ```diff for statement in pipeline.statements: - if isinstance(statement, IfNode): - results.append(await self._execute_if(statement, istream, env)) - elif isinstance(statement, WhileNode): - results.append(await self._execute_while(statement, istream, env)) - else: - results.append(await self._execute_group(statement, istream, env)) + try: + if isinstance(statement, IfNode): + results.append(await self._execute_if(statement, istream, env)) + elif isinstance(statement, WhileNode): + results.append(await self._execute_while(statement, istream, env)) + else: + results.append(await self._execute_group(statement, istream, env)) + except Exception as e: + logger.error(f"Pipeline execution failed: {e}") + logger.exception(e) + results.append( + TextHandleResult(code=-1, ostream="处理流水线时出现 python 错误") + ) + return results ``` <details><summary>Suggestion importance[1-10]: 6</summary> __ Why: The suggestion correctly observes that the old code had `try/except` wrapping pipeline execution, and the new code removes it. Unhandled exceptions in `_execute_if`, `_execute_while`, or `_execute_group` could propagate and crash the bot or expose raw tracebacks. However, it's possible the exception handling was moved into those helper methods (which aren't shown in the diff), so this is a reasonable but not certain concern. The `improved_code` accurately reflects the suggested change. </details></details></td><td align=center>Low </td></tr><tr><td> <details><summary>方括号别名检测逻辑永远不生效</summary> ___ **当 <code>THTest</code> 通过 <code>keywords = ["["]</code> 以 <code>[</code> 别名被调用时，这里的 <code>self.name</code> 始终是 <code>"test"</code>，不会等于 <br><code>"["</code>，因此永远不会进入该分支。应该通过检查参数（例如 <code>args</code> 的第一个元素或调用名）来判断是否以 <code>[</code> 形式调用，并在此时验证末尾是否有匹配的 <br><code>]</code>，否则报错提示语法不正确。** [konabot/plugins/handle_text/handlers/unix_handlers.py [121-122]](https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/feat/textfx-minishell/konabot/plugins/handle_text/handlers/unix_handlers.py#L121-L122) ```diff -if self.name == "[": - pass +# Note: bracket-style invocation detection should be based on +# the actual invoked name passed by the caller, not self.name. +# If the caller does not pass invoked name, consider checking +# if the last arg is ']' and require it for bracket syntax. ``` <details><summary>Suggestion importance[1-10]: 5</summary> __ Why: The suggestion correctly identifies that `self.name` is always `"test"` since `keywords` only adds aliases for lookup, not for changing `self.name`. However, the `improved_code` is just comments rather than actual working code, and the current code still handles `]` removal on line 124-125 regardless of invocation method, so the practical impact is limited — the bracket syntax still works, just without strict validation of the closing `]`. </details></details></td><td align=center>Low </td></tr></tr></tbody></table> </details>

pi-agent force-pushed feat/textfx-minishell from 0cb236b561 to 805e60a9ff

2026-03-18 18:16:05 +08:00

Compare

kagami-review commented

2026-03-18 18:16:50 +08:00

Persistent review updated to latest commit 8f40572a38

**[Persistent review](https://gitea.service.jazzwhom.top/mttu-developers/konabot/pulls/62#issuecomment-361)** updated to latest commit https://gitea.service.jazzwhom.top/mttu-developers/konabot/commit/8f40572a389a53ec4869af892d8df4292893a66a

Passthem merged commit bfb8ebab29 into master

2026-03-18 19:14:48 +08:00

Passthem referenced this issue from a commit

2026-03-18 19:14:50 +08:00

Merge pull request 'feat: evolve textfx into a mini shell' (#62) from pi-agent/konabot:feat/textfx-minishell into master

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mttu-developers/konabot#62

Allow edits from maintainers

feat: evolve textfx into a mini shell #62

User description

概述

主要变更

架构重构

新增 shell-like 语法

新增内建命令

安全限制

测试

文档

PR Type

Description

Diagram Walkthrough

File Walkthrough

PR Reviewer Guide 🔍

(Review updated until commit 8f40572a38)

PR Code Suggestions ✨

Previous suggestions

(Review updated until commit `8f40572a38`)