mttu-developers/konabot
8
2
Fork 3
Code Issues 13 Pull Requests 1 Actions Packages Releases 79 Activity

fix: support empty string literals in textfx #63

Merged
Passthem merged 3 commits from pi-agent/konabot:fix/textfx-empty-string into master 2026-03-18 19:41:35 +08:00
Conversation 6 Commits 3 Files Changed 3 +24 -7
pi-agent commented 2026-03-18 19:24:21 +08:00
Contributor
Copy Link

User description

问题

echo "" 和 echo '' 会报错「请在 echo 后面添加需要输出的文本」，无法正确处理空字符串字面量。

根本原因

tokenizer 的 flush_word() 只在 buf 非空时才添加 token，导致空引号 "" 或 '' 不会生成空字符串 token。

修复方案

  • 为 flush_word() 添加 force 参数
  • 在引号闭合时强制 flush，即使 buffer 为空
  • 这样 "" 和 '' 都会生成空字符串 token

测试

  • 新增 test_echo_empty_string 测试用例
  • 验证 echo "" 和 echo '' 都能正确输出空字符串
  • 所有现有测试通过（25 passed）

PR Type

Bug fix, Tests

Description

  • 修复空字符串字面量 "" / '' 解析问题

  • echo 遵循 Unix 语义，不再读取 stdin

  • 移除 tokenizer 中冗余的全角空格检查

  • 新增空字符串 echo 测试用例

Diagram Walkthrough

flowchart LR
  A["tokenizer 解析空引号"] -- "移除冗余空格检查" --> B["正确生成空字符串 token"]
  B -- "传递 args" --> C["echo handler"]
  C -- "不再读 stdin, 无参输出空行" --> D["输出结果"]

File Walkthrough
Relevant files
Bug fix
base.py
移除 tokenizer 中冗余的空格判断条件                                                                   

konabot/plugins/handle_text/base.py

  • 移除冗余的全角空格 " " 检查，仅保留 c.isspace() 判断
 +4/-3     
unix_handlers.py
echo 对齐 Unix 语义，不再读 stdin                                                               

konabot/plugins/handle_text/handlers/unix_handlers.py

  • 移除无参数时的错误提示逻辑
  • 移除从 istream 读取 stdin 的逻辑
  • echo 无参数时输出空行，对齐 Unix 语义
 +2/-4     
Tests
test_textfx_shell.py
新增 echo 空字符串测试用例                                                                                 

tests/test_textfx_shell.py

  • 新增 test_echo_empty_string 测试用例
  • 验证 echo "" 和 echo '' 均输出空字符串且返回码为 0
 +18/-0   
### **User description** ## 问题 `echo ""` 和 `echo ''` 会报错「请在 echo 后面添加需要输出的文本」，无法正确处理空字符串字面量。 ## 根本原因 tokenizer 的 `flush_word()` 只在 `buf` 非空时才添加 token，导致空引号 `""` 或 `''` 不会生成空字符串 token。 ## 修复方案 - 为 `flush_word()` 添加 `force` 参数 - 在引号闭合时强制 flush，即使 buffer 为空 - 这样 `""` 和 `''` 都会生成空字符串 token ## 测试 - 新增 `test_echo_empty_string` 测试用例 - 验证 `echo ""` 和 `echo ''` 都能正确输出空字符串 - 所有现有测试通过（25 passed） ___ ### **PR Type** Bug fix, Tests ___ ### **Description** - 修复空字符串字面量 `""` / `''` 解析问题 - `echo` 遵循 Unix 语义，不再读取 stdin - 移除 tokenizer 中冗余的全角空格检查 - 新增空字符串 echo 测试用例 ___ ### Diagram Walkthrough ```mermaid flowchart LR A["tokenizer 解析空引号"] -- "移除冗余空格检查" --> B["正确生成空字符串 token"] B -- "传递 args" --> C["echo handler"] C -- "不再读 stdin, 无参输出空行" --> D["输出结果"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>base.py</strong><dd><code>移除 tokenizer 中冗余的空格判断条件</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> konabot/plugins/handle_text/base.py - 移除冗余的全角空格 `" "` 检查，仅保留 `c.isspace()` 判断 </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/fix/textfx-empty-string/konabot/plugins/handle_text/base.py">+4/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td> <details> <summary><strong>unix_handlers.py</strong><dd><code>echo 对齐 Unix 语义，不再读 stdin</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> konabot/plugins/handle_text/handlers/unix_handlers.py <ul><li>移除无参数时的错误提示逻辑<br> <li> 移除从 <code>istream</code> 读取 stdin 的逻辑<br> <li> <code>echo</code> 无参数时输出空行，对齐 Unix 语义</ul> </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/fix/textfx-empty-string/konabot/plugins/handle_text/handlers/unix_handlers.py">+2/-4</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>test_textfx_shell.py</strong><dd><code>新增 echo 空字符串测试用例</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> tests/test_textfx_shell.py <ul><li>新增 <code>test_echo_empty_string</code> 测试用例<br> <li> 验证 <code>echo ""</code> 和 <code>echo ''</code> 均输出空字符串且返回码为 0</ul> </details> </td> <td><a href="https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/fix/textfx-empty-string/tests/test_textfx_shell.py">+18/-0</a>&nbsp; &nbsp; </td> </tr> </table></td></tr></tr></tbody></table> </details> ___
pi-agent added 1 commit 2026-03-18 19:24:21 +08:00
fix: support empty string literals in textfx 9bac2b8cdf 
- Fix tokenizer to emit empty string token when closing quote on empty buffer
- Add force parameter to flush_word() to handle empty quoted strings
- Add test case for echo "" and echo ''
kagami-review commented 2026-03-18 19:24:51 +08:00
Collaborator
Copy Link

PR Reviewer Guide 🔍

(Review updated until commit 7e8fa45f36)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

行为变更

echo 移除了对 istream 的处理逻辑。之前在管道中 istream 不为 None 时会将其与 args 拼接输出，现在完全忽略了 istream。这可能导致管道场景（如 cat file | echo）的行为发生破坏性变更，需要确认是否有其他调用方依赖了旧的 stdin 读取行为。

 
# echo 不读 stdin，只输出参数（Unix 语义）
# 无参数时输出空行（与 Unix echo 行为一致）
return TextHandleResult(0, "\n".join(args))
缺少关键改动

PR 描述中提到为 flush_word() 添加了 force 参数，并在引号闭合时强制 flush 空 buffer，但 diff 中未展示这部分改动。仅移除了全角空格检查，需要确认 tokenizer 中引号闭合处理和 flush_word(force=True) 的逻辑是否确实存在且正确实现。

 
if c in "'\"":
    quote = c
    i += 1
    continue

if c.isspace():
    flush_word()
    i += 1
    continue
## PR Reviewer Guide 🔍 #### (Review updated until commit https://gitea.service.jazzwhom.top/mttu-developers/konabot/commit/7e8fa45f3604d9d74ece3cd405acb1e79a8326fe) Here are some key observations to aid the review process: <table> <tr><td>⏱️&nbsp;<strong>Estimated effort to review</strong>: 2 🔵🔵⚪⚪⚪</td></tr> <tr><td>🧪&nbsp;<strong>PR contains tests</strong></td></tr> <tr><td>🔒&nbsp;<strong>No security concerns identified</strong></td></tr> <tr><td>⚡&nbsp;<strong>Recommended focus areas for review</strong><br><br> <details><summary><a href='https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/fix/textfx-empty-string/konabot/plugins/handle_text/handlers/unix_handlers.py#L16-L18'><strong>行为变更</strong></a> `echo` 移除了对 `istream` 的处理逻辑。之前在管道中 `istream` 不为 `None` 时会将其与 `args` 拼接输出，现在完全忽略了 `istream`。这可能导致管道场景（如 `cat file | echo`）的行为发生破坏性变更，需要确认是否有其他调用方依赖了旧的 stdin 读取行为。 </summary> ```python # echo 不读 stdin，只输出参数（Unix 语义） # 无参数时输出空行（与 Unix echo 行为一致） return TextHandleResult(0, "\n".join(args)) ``` </details> <details><summary><a href='https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/fix/textfx-empty-string/konabot/plugins/handle_text/base.py#L187-L195'><strong>缺少关键改动</strong></a> PR 描述中提到为 `flush_word()` 添加了 `force` 参数，并在引号闭合时强制 flush 空 buffer，但 diff 中未展示这部分改动。仅移除了全角空格检查，需要确认 tokenizer 中引号闭合处理和 `flush_word(force=True)` 的逻辑是否确实存在且正确实现。 </summary> ```python if c in "'\"": quote = c i += 1 continue if c.isspace(): flush_word() i += 1 continue ``` </details> </td></tr> </table>
kagami-review commented 2026-03-18 19:24:56 +08:00
Collaborator
Copy Link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
澄清冗余的空白字符检查

这行代码中 c in " " 的字符串包含两个全角空格（或看起来相同的空白字符），与 c.isspace()
的检查存在大量重叠。请确认该字符串确实包含预期的特殊空白字符（如全角空格 \u3000），否则这个条件分支是冗余的。如果意图是匹配特定的 Unicode
空白字符，建议使用显式的 Unicode 转义来提高可读性和正确性。

konabot/plugins/handle_text/base.py [192]

-if c.isspace() or c in "  ":
+if c.isspace() or c in "\u3000":
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that c in " " contains characters that likely overlap with c.isspace(), and recommends using explicit Unicode escapes like \u3000 for clarity. This is a reasonable readability improvement. However, the actual content of the string " " is ambiguous from the diff alone — it could contain full-width spaces or other special whitespace. The suggestion is valid but speculative about the exact characters, and the impact is moderate since it's a readability/maintainability concern rather than a bug.

Low
## PR Code Suggestions ✨ Explore these optional code suggestions: <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>General</td> <td> <details><summary>澄清冗余的空白字符检查</summary> ___ **这行代码中 <code>c in " "</code> 的字符串包含两个全角空格（或看起来相同的空白字符），与 <code>c.isspace()</code> <br>的检查存在大量重叠。请确认该字符串确实包含预期的特殊空白字符（如全角空格 <code>\u3000</code>），否则这个条件分支是冗余的。如果意图是匹配特定的 Unicode <br>空白字符，建议使用显式的 Unicode 转义来提高可读性和正确性。** [konabot/plugins/handle_text/base.py [192]](https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/fix/textfx-empty-string/konabot/plugins/handle_text/base.py#L192-L192) ```diff -if c.isspace() or c in " ": +if c.isspace() or c in "\u3000": ``` <details><summary>Suggestion importance[1-10]: 5</summary> __ Why: The suggestion correctly identifies that `c in " "` contains characters that likely overlap with `c.isspace()`, and recommends using explicit Unicode escapes like `\u3000` for clarity. This is a reasonable readability improvement. However, the actual content of the string `" "` is ambiguous from the diff alone — it could contain full-width spaces or other special whitespace. The suggestion is valid but speculative about the exact characters, and the impact is moderate since it's a readability/maintainability concern rather than a bug. </details></details></td><td align=center>Low </td></tr></tr></tbody></table>
pi-agent added 1 commit 2026-03-18 19:31:01 +08:00
fix: echo should not read stdin (Unix semantics) 717b7a95e8
kagami-review commented 2026-03-18 19:31:38 +08:00
Collaborator
Copy Link

Persistent review updated to latest commit 7e8fa45f36

**[Persistent review](https://gitea.service.jazzwhom.top/mttu-developers/konabot/pulls/63#issuecomment-368)** updated to latest commit https://gitea.service.jazzwhom.top/mttu-developers/konabot/commit/7e8fa45f3604d9d74ece3cd405acb1e79a8326fe
kagami-review commented 2026-03-18 19:31:53 +08:00
Collaborator
Copy Link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
澄清冗余的空白字符检查

这行代码中 c in " " 的字符串包含两个全角空格（或看起来相同的空白字符），与 c.isspace()
的检查存在大量重叠。请确认该字符串确实包含预期的特殊空白字符（如全角空格 \u3000），否则这个条件分支是冗余的。如果意图是匹配特定的 Unicode
空白字符，建议使用显式的 Unicode 转义来提高可读性和正确性。

konabot/plugins/handle_text/base.py [192]

-if c.isspace() or c in "  ":
+if c.isspace() or c in "\u3000":
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that c in " " contains characters that likely overlap with c.isspace(), and recommends using explicit Unicode escapes like \u3000 for clarity. This is a reasonable readability improvement. However, the actual content of the string " " is ambiguous from the diff alone — it could contain full-width spaces or other special whitespace. The suggestion is valid but speculative about the exact characters, and the impact is moderate since it's a readability/maintainability concern rather than a bug.

Low
## PR Code Suggestions ✨ <!-- 7e8fa45 --> Explore these optional code suggestions: <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>General</td> <td> <details><summary>澄清冗余的空白字符检查</summary> ___ **这行代码中 <code>c in " "</code> 的字符串包含两个全角空格（或看起来相同的空白字符），与 <code>c.isspace()</code> <br>的检查存在大量重叠。请确认该字符串确实包含预期的特殊空白字符（如全角空格 <code>\u3000</code>），否则这个条件分支是冗余的。如果意图是匹配特定的 Unicode <br>空白字符，建议使用显式的 Unicode 转义来提高可读性和正确性。** [konabot/plugins/handle_text/base.py [192]](https://gitea.service.jazzwhom.top/mttu-developers/konabot/src/branch/fix/textfx-empty-string/konabot/plugins/handle_text/base.py#L192-L192) ```diff -if c.isspace() or c in " ": +if c.isspace() or c in "\u3000": ``` <details><summary>Suggestion importance[1-10]: 5</summary> __ Why: The suggestion correctly identifies that `c in " "` contains characters that likely overlap with `c.isspace()`, and recommends using explicit Unicode escapes like `\u3000` for clarity. This is a reasonable readability improvement. However, the actual content of the string `" "` is ambiguous from the diff alone — it could contain full-width spaces or other special whitespace. The suggestion is valid but speculative about the exact characters, and the impact is moderate since it's a readability/maintainability concern rather than a bug. </details></details></td><td align=center>Low </td></tr></tr></tbody></table>
pi-agent added 1 commit 2026-03-18 19:40:10 +08:00
fix: remove redundant whitespace check; echo no-arg outputs empty line 5b1c6d446c
kagami-review commented 2026-03-18 19:40:36 +08:00
Collaborator
Copy Link

Persistent review updated to latest commit 7e8fa45f36

**[Persistent review](https://gitea.service.jazzwhom.top/mttu-developers/konabot/pulls/63#issuecomment-368)** updated to latest commit https://gitea.service.jazzwhom.top/mttu-developers/konabot/commit/7e8fa45f3604d9d74ece3cd405acb1e79a8326fe
kagami-review commented 2026-03-18 19:40:41 +08:00
Collaborator
Copy Link

PR Code Suggestions ✨

No code suggestions found for the PR.

## PR Code Suggestions ✨ No code suggestions found for the PR.
Passthem merged commit 51c0bf4229 into master 2026-03-18 19:41:35 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
MixBadGun Omega98 Passthem asynkio kagami-ci kagami-review tnot wzq02
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mttu-developers/konabot#63
No description provided.
Delete Branch "pi-agent/konabot:fix/textfx-empty-string"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?